Re: pg_xlogdump fails to handle WAL file with multi-page XLP_FIRST_IS_CONTRECORD data
| От | Craig Ringer |
|---|---|
| Тема | Re: pg_xlogdump fails to handle WAL file with multi-page XLP_FIRST_IS_CONTRECORD data |
| Дата | |
| Msg-id | CAMsr+YH4wm0KRyupxu6atdc+tgfQyrbVxwY3_2wguELuQw0Gjw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pg_xlogdump fails to handle WAL file with multi-page XLP_FIRST_IS_CONTRECORD data (Pavan Deolasee <pavan.deolasee@gmail.com>) |
| Список | pgsql-hackers |
On 23 March 2016 at 18:04, Pavan Deolasee <pavan.deolasee@gmail.com> wrote:
On Wed, Mar 23, 2016 at 1:13 PM, Michael Paquier <michael.paquier@gmail.com> wrote:
+ /*
+ * Compute targetRecOff. It should typically be greater than short
+ * page-header since a valid record can't , but can also be zero when
+ * caller has supplied a page-aligned address or when we are skipping
+ * multi-page continuation record. It doesn't matter though because
+ * ReadPageInternal() will read at least short page-header worth of
+ * data
+ */
This needs some polishing, there is an unfinished sentence here.
+ targetRecOff = tmpRecPtr % XLOG_BLCKSZ;
targetRecOff, pageHeaderSize and targetPagePtr could be declared
inside directly the new while loop.Thanks Michael for reviewing the patch. I've fixed these issues and new version is attached.
Looks sensible to me based on a reading of "git diff -w" of the applied patch. It passes make check and make -C src/test/recovery check . Marked ready for committer; I'd like to add a TAP test for it, but it's ready to go without that.
В списке pgsql-hackers по дате отправления: