On 2016-03-15 21:04:12 +0800, Craig Ringer wrote: > Thanks very much for the review.
Are you planning to update the patch?
Updated patch attached.
It removes the questionable cleanups, fixes the randAccess comment (IMO), changes the "open a new xlog segment" wording and explains why we don't need GetFlushRecPtr/GetXLogReplayRecPtr on replay of a historical timeline. I removed the change that did less than a whole page at the XLogRead call and instead added a comment explaining it. Fixed the brainfrart with candidate_restart_lsn, removed the outdated startptr comment and update and the unnecessary XLogReaderInvalCache call after it.
Also renamed src/test/modules/decoding_failover to src/test/modules/test_slot_timelines . Best name I could come up with that wasn't 1000chars long.
Passes main 'check', contrib/test_decoding check, src/test/modules/test_slot_timelines check and src/test/recovery check.