Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?

Поиск
Список
Период
Сортировка
От Jeff Janes
Тема Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?
Дата
Msg-id CAMkU=1xM9qPo=znyXtzrLCsu=0kg2QwqxJR_iS=waJTj5RJPBw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [HACKERS] tablesync patch broke the assumption that logical repdepends on?  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: [HACKERS] tablesync patch broke the assumption that logical rep depends on?  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Дерево обсуждения
On Wed, Apr 26, 2017 at 8:00 AM, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
On 4/25/17 15:42, Petr Jelinek wrote:
>> Here is the patch doing just that.
>
> And one more revision which also checks in_use when attaching shared
> memory. This is mainly to improve the user visible behavior in
> theoretical corner case when the worker is supposed to be cleaned up but
> actually still manages to start (it would still fail even without this
> change but the error message would be more obscure).

Committed that, with some editorializing.

This gives me compiler warning:

launcher.c: In function 'logicalrep_worker_launch':
launcher.c:257: warning: 'slot' may be used uninitialized in this function

gcc version 4.4.7 20120313 (Red Hat 4.4.7-18) (GCC)


Cheers,

Jeff

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: [HACKERS] [PATCH] Incremental sort
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Unportable implementation of background worker start