Re: pgcrypto: PGP armor headers
| От | Jeff Janes |
|---|---|
| Тема | Re: pgcrypto: PGP armor headers |
| Дата | |
| Msg-id | CAMkU=1x-PZ+n_d2OzqMes+RvCDRKsR-LhqANe-efciTwsH-3wg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: pgcrypto: PGP armor headers (Marko Tiikkaja <marko@joh.to>) |
| Список | pgsql-hackers |
On Fri, Aug 15, 2014 at 1:55 AM, Marko Tiikkaja <marko@joh.to> wrote:
I didn't do a detailed code review, and I am not a security expert, so I will leave it to the signed-up reviewer to change the status once he takes a look.
Hi,Latest version of the patch here, having fixed some small coding issues.
On 8/8/14 3:18 PM, I wrote:Currently there's no way to generate or extract armor headers from the
PGP armored format in pgcrypto. I've written a patch to add the
support.
I've built this and tested the installation of the extension, the upgrade from earlier versions, and the basic functions, with and without --enable-cassert
I did occasionally get some failures with 'make check -C contrib/pgcrypto', but I can't reproduce it. I might have accidentally had some mixture of binaries some with cassert and some without.
No other problems to report.
One quibble in the documentation, "an error is returned". Errors get raised, not returned.
This patch will conflict with the pgp signature patch due to the pgcrypto--1.2.sql and kin.
Cheers,
Jeff
В списке pgsql-hackers по дате отправления: