Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes thereshould be per DATA() line
| От | Jeff Janes |
|---|---|
| Тема | Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes thereshould be per DATA() line |
| Дата | |
| Msg-id | CAMkU=1wuQW=xVfu-14A4VCvxO0ohkD3m9vk6HOj_dprQoKNAQw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes thereshould be per DATA() line (Robert Haas <robertmhaas@gmail.com>) |
| Ответы |
Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes thereshould be per DATA() line
Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line |
| Список | pgsql-hackers |
On Thu, Mar 9, 2017 at 3:20 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Mon, Mar 6, 2017 at 11:37 AM, Dagfinn Ilmari Mannsåker
<ilmari@ilmari.org> wrote:
> David Christensen <david@endpoint.com> writes:
>>> Hi David,
>>>
>>> Here's a review of your patch.
>>
>> Hi Ilmari, thanks for your time and review. I’m fine with the revised version.
>
> Okay, I've marked the patch as Ready For Committer.
Committed. Hopefully this doesn't contain any Perl bits that are
sufficiently new as to cause problems for our older BF members ... I
guess we'll see.
Bad luck there. I'm getting this error on CentOS6.8, perl v5.10.1
Can't locate object method "input_line_number" via package "IO::Handle" at ../../../src/backend/catalog/Catalog.pm line 82, <INPUT_FILE> line 148.
make[3]: *** [fmgrtab.c] Error 25
make[2]: *** [utils/fmgroids.h] Error 2
make[2]: *** Waiting for unfinished jobs....
Can't locate object method "input_line_number" via package "IO::Handle" at ../../../src/backend/catalog/Catalog.pm line 82, <INPUT_FILE> line 148.
make[3]: *** [postgres.bki] Error 25
make[2]: *** [submake-schemapg] Error 2
make[1]: *** [all-backend-recurse] Error 2
make: *** [all-src-recurse] Error 2
I think we can just save $. and use that, as in the attached.
I as sabotaged a random line in src/include/catalog/pg_amop.h and it seems to report the error correctly.
Cheers,
Jeff
Вложения
В списке pgsql-hackers по дате отправления: