Re: Adding OLD/NEW support to RETURNING

On Fri, Jan 17, 2025 at 12:28 AM Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> I went over this again in detail and didn't find any problems, so I
> have committed it. Thanks for all the review comments.

It seems that adding ParseNamespaceItems for the OLD or NEW aliases
may confuse scanNameSpaceForRelid() when searching the table namespace
for a relation item.  Since they contain the same RTE,
scanNameSpaceForRelid() might mistakenly detect multiple matches.

create table t (a int, b int);

update public.t set a = 1 returning public.t.b;
ERROR:  table reference 46337 is ambiguous
LINE 1: update public.t set a = 1 returning public.t.b;
                                            ^
Thanks
Richard