Re: [PATCH] Simple code cleanup in tuplesort.c.
| От | Richard Guo |
|---|---|
| Тема | Re: [PATCH] Simple code cleanup in tuplesort.c. |
| Дата | |
| Msg-id | CAMbWs4-Mn=jBwaiXCLi1WvPsw3Hc-5MDf-zBTwZVwfkwFNvQ+Q@mail.gmail.com обсуждение исходный текст |
| Ответ на | [PATCH] Simple code cleanup in tuplesort.c. (Xing Guo <higuoxing@gmail.com>) |
| Ответы |
Re: [PATCH] Simple code cleanup in tuplesort.c.
Re: [PATCH] Simple code cleanup in tuplesort.c. |
| Список | pgsql-hackers |
On Wed, Jul 27, 2022 at 5:10 PM Xing Guo <higuoxing@gmail.com> wrote:
The bounded heap sorting status flag is set twice in sort_bounded_heap() and tuplesort_performsort(). This patch helps remove one of them.
Revisiting this patch I think maybe it's better to remove the setting of
Tuplesort status from tuplesort_performsort() for the TSS_BOUNDED case.
Thus we keep the heap manipulation routines, make_bounded_heap and
sort_bounded_heap, consistent in that they update their status
accordingly inside the function.
Also, would you please add it to the CF to not lose track of it?
Thanks
Richard
Tuplesort status from tuplesort_performsort() for the TSS_BOUNDED case.
Thus we keep the heap manipulation routines, make_bounded_heap and
sort_bounded_heap, consistent in that they update their status
accordingly inside the function.
Also, would you please add it to the CF to not lose track of it?
Thanks
Richard
В списке pgsql-hackers по дате отправления: