Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
От | Yogesh Mahajan |
---|---|
Тема | Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React. |
Дата | |
Msg-id | CAMa=N=NqKQt4MWaK42FHuCCyxDLbN3J8hXNtrtUJPpB8FG=-aw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React. (Akshay Joshi <akshay.joshi@enterprisedb.com>) |
Ответы |
Re: [pgAdmin][Patch] - Housekeeping #7017- [React] Port Import Export dialog to React.
|
Список | pgadmin-hackers |
Hello Team,
Please find the attached patch which fixes the issue of duplicate values shown in Column>Columns to Import/Export dropdown when a value(values) is unselected.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Fri, Jan 21, 2022 at 11:52 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.On Thu, Jan 20, 2022 at 3:18 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi,Please find the attached patch which fixes all comments given below.Thanks,Yogesh MahajanEnterpriseDBOn Wed, Jan 19, 2022 at 7:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi YogeshFollowing are the review comments:
- Increase the height of the dialog to avoid the scroll bars. Check the height of the backup dialog.
- The 'OK' button should be disabled and the validation message 'Please provide a file name.' should be shown the first time when the dialog is opened. Check backup dialog
- The help button should be enabled and check it refers to the appropriate page.
- Update the documentation and screenshots.
On Wed, Jan 19, 2022 at 12:52 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:Hi Hackers,Please find the patch which port import/export data dialogue to react.Thanks,Yogesh MahajanEnterpriseDB--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Вложения
В списке pgadmin-hackers по дате отправления: