Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure
| От | Yogesh Mahajan |
|---|---|
| Тема | Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure |
| Дата | |
| Msg-id | CAMa=N=N7OxP7TNw3yNUZsA3CJDuKOoCbp9XJbHiDLZpR2_cBUQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure (Khushboo Vashi <khushboo.vashi@enterprisedb.com>) |
| Ответы |
Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure
|
| Список | pgadmin-hackers |
Hi,
Please find the updated patch with documentation.
On Mon, Jun 6, 2022 at 1:10 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Yogesh,
Review comments:
- Step 2: The below statements should be in a different line, like
- "Azure CLI" will use the currently logged in identity through Azure CLI on the local machine.
- "Interactive Browser" opens a browser to authenticate a user interactively.
Done.
- Disable the next button once authentication is complete.
As discussed disabled Authentication button once authentication is completed.
- Cluster name availability call calls the server on every field change
Done.
- Availability zone needs description
This is a generic term with cloud hence not added.
- Add High availability option
Done
Code:
- check_cluster_name_availability should be using the GET method instead of Post
Done.
- Fix SonarLint issues
Done.
- Do we need the cache_persistence_options as it will create the persistent storage which we do not require I guess?
Yes, it is required.
- Why do we need to call _get_azure_credentials on every request? Can't we store it in the session object?
Function returns without calling again credentials if an existing client is present.
- Use gettext wherever required in the js file
Done.
Thanks,Khushboo
Yogesh Mahajan
EnterpriseDB
On Wed, 1 Jun 2022, 10:11 Yogesh Mahajan, <yogesh.mahajan@enterprisedb.com> wrote:Hi,Please find the attached patch which provides functionality to deploy a Postgres cloud instance on Azure Postgresql.Thanks,Yogesh MahajanEnterpriseDB
Вложения
В списке pgadmin-hackers по дате отправления: