Re: On login trigger: take three
| От | Mikhail Gribkov |
|---|---|
| Тема | Re: On login trigger: take three |
| Дата | |
| Msg-id | CAMEv5_uSfF6B6dSB4-w4c2FffJrsX2=qoahSTqJK8V6HZhe1sg@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: On login trigger: take three (Pavel Stehule <pavel.stehule@gmail.com>) |
| Ответы |
Re: On login trigger: take three
|
| Список | pgsql-hackers |
Hi Pavel,
Thanks for pointing out the tests. I completely agree that using an exception inside on-login trigger should be tested. It cannot be done via regular *.sql/*.out regress tests, thus I have added another perl test to authentication group doing this.
Attached v36 patch contains this test along with the fresh rebase on master.
--
On Thu, Jan 12, 2023 at 9:51 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
HiI checked this patch and it looks well. All tests passed. Together with https://commitfest.postgresql.org/41/4013/ it can be a good feature.I re-tested impact on performance and for the worst case looks like less than 1% (0.8%). I think it is acceptable. Tested pgbench scenario "SELECT 1"pgbench -f ~/test.sql -C -c 3 -j 5 -T 100 -P10 postgres733 tps (master), 727 tps (patched).I think raising an exception inside should be better tested - not it is only in 001_stream_rep.pl - generally more tests are welcome - there are no tested handling exceptions.RegardsPavel
Вложения
В списке pgsql-hackers по дате отправления: