On Wed, Mar 15, 2023 at 8:45 PM Gregory Stark (as CFM) <stark.cfm@gmail.com> wrote:
It looks like the patch is failing a test by not dumping login_event_trigger_func? I'm guessing there's a race condition in the test but I don't know. I also don't see the tmp_test_jI6t output file being preserved in the artifacts anywhere :(
[16:16:48.594] # Looks like you failed 1 test of 10350.
# Running: pg_dump --no-sync --file=/tmp/cirrus-ci-build/src/bin/pg_dump/tmp_check/tmp_test_jI6t/only_dump_measurement.sql --table-and-children=dump_test.measurement --lock-wait-timeout=180000 postgres [16:16:27.027](0.154s) ok 6765 - only_dump_measurement: pg_dump runs ..... [16:16:27.035](0.000s) not ok 6870 - only_dump_measurement: should dump CREATE FUNCTION dump_test.login_event_trigger_func [16:16:27.035](0.000s) [16:16:27.035](0.000s) # Failed test 'only_dump_measurement: should dump CREATE FUNCTION dump_test.login_event_trigger_func' # at t/002_pg_dump.pl line 4761. ..... [16:16:48.594] +++ tap check in src/bin/pg_dump +++ [16:16:48.594] [16:16:05] t/001_basic.pl ................ ok 612 ms ( 0.01 usr 0.00 sys + 0.24 cusr 0.26 csys = 0.51 CPU) [16:16:48.594] [16:16:48.594] # Failed test 'only_dump_measurement: should dump CREATE FUNCTION dump_test.login_event_trigger_func' [16:16:48.594] # at t/002_pg_dump.pl line 4761. [16:16:48.594] # Review only_dump_measurement results in /tmp/cirrus-ci-build/src/bin/pg_dump/tmp_check/tmp_test_jI6t