Re: On login trigger: take three
| От | Mikhail Gribkov |
|---|---|
| Тема | Re: On login trigger: take three |
| Дата | |
| Msg-id | CAMEv5_s=s2ZATDf3Zo11naH+25OKuoLyOxtPO+bKPB=qdMd4HQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: On login trigger: take three (Alexander Korotkov <aekorotkov@gmail.com>) |
| Список | pgsql-hackers |
Hi Alexander,
Sorry for my long offline and thanks for the activity. So should we close the patch on the commitfest page now?
By the way I had one more issue with the login trigger tests (quite a rare one though). A race condition may occur on some systems, when oidjoins test starts a moment later than normally and affects logins count for on-login trigger test. Thus I had to split event_trigger and oidjoins tests into separate parallel groups. I'll post this as an independent patch then.
--
On Mon, Oct 16, 2023 at 4:05 AM Alexander Korotkov <aekorotkov@gmail.com> wrote:
On Mon, Oct 16, 2023 at 4:00 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Oct 16, 2023 at 02:47:03AM +0300, Alexander Korotkov wrote:
> > The attached revision fixes test failures spotted by
> > commitfest.cputube.org. Also, perl scripts passed perltidy.
>
> Still you've missed a few things. At quick glance:
> - The code indentation was off a bit in event_trigger.c.
> - 005_login_trigger.pl fails if the code is compiled with
> ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS because a WARNING is
> reported in test "create tmp objects: err equals".
> - 005_sspi.pl is older than the new test 005_login_trigger.pl, could
> you rename it with a different number?
You are very fast and sharp eye!
Thank you for fixing the indentation. I just pushed fixes for the rest.
------
Regards,
Alexander Korotkov
В списке pgsql-hackers по дате отправления: