Re: [pgAdmin][SonarQube] Cognitive complexity

Поиск
Список
Период
Сортировка
От Aditya Toshniwal
Тема Re: [pgAdmin][SonarQube] Cognitive complexity
Дата
Msg-id CAM9w-_njz5LiXmUBCNTxPd49e=Z6iwOeu804JPO_PHc=WrnZQQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][SonarQube] Cognitive complexity  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin][SonarQube] Cognitive complexity
Список pgadmin-hackers
Дерево обсуждения
Hi Hackers,

The previous commit caused a regression in taking backup of table. DB and schema backup worked fine.
Attached patch fixes the regression.
I've also added more test scenarios in backup test cases covering table and schema backups to catch the failure earlier.

On Tue, Aug 25, 2020 at 12:42 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.

On Tue, Aug 25, 2020 at 12:32 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Akshay,

Attached is the updated patch.

On Tue, Aug 25, 2020 at 11:38 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

Please fix the following issues:
  • Add docstrings to the newly created functions.
  • Fix PEP8 issue.


On Mon, Aug 24, 2020 at 5:02 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch reduces the cognitive complexity of functions for below:
web/.../schemas/packages/edbfuncs/__init__.py 21 to 15
web/.../databases/schemas/types/__init__.py 39 to 15; 80 to 15
web/.../server_groups/servers/pgagent/__init__.py 39 to 15
web/pgadmin/misc/bgprocess/process_executor.py 19 to 15
web/pgadmin/tools/backup/__init__.py 54 to 15

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Вложения

В списке pgadmin-hackers по дате отправления: