Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images inexplain plan only when user try to download it
От | Aditya Toshniwal |
---|---|
Тема | Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images inexplain plan only when user try to download it |
Дата | |
Msg-id | CAM9w-_nb7_qEty4tKpp756OdtsE2izrqx8GMFksmCFpWE4cL7w@mail.gmail.com обсуждение исходный текст |
Ответ на | [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images in explainplan only when user try to download it (Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>) |
Ответы |
Re: [RM#4307][pgAdmin4] Graphical Explain Plan - Embed images inexplain plan only when user try to download it
|
Список | pgadmin-hackers |
Hi Murtuza,
I was just going through code change, and I would suggest one small change.
In the image_mapper.js, export it as default, as it will have only one export. Then you can use it as imageMapper.default rather than imageMapper.imageMapper.
Otherwise, looks fine to me. I didn't test though :P
On Thu, May 30, 2019 at 2:41 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,Embedding images using .toDataURL() method hits the performance of the explain plan rendering if the plan is complex because first it downloads the images then it will convert each images into base64, to improve the performance we will embed the images only when downloading of SVG is called and not when displaying the graphical plan.--Regards,
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
В списке pgadmin-hackers по дате отправления: