Re: [pgAdmin][RM4506] "can't execute an empty query" messagedisplayed if user remove fill factor of any existing table

Поиск
Список
Период
Сортировка
От Aditya Toshniwal
Тема Re: [pgAdmin][RM4506] "can't execute an empty query" messagedisplayed if user remove fill factor of any existing table
Дата
Msg-id CAM9w-_mv1jj3WA01GC4jBU4mv+kGvGruLZVC=qJJCjx97nYQCQ@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin][RM4506] "can't execute an empty query" messagedisplayed if user remove fill factor of any existing table  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Ответы Re: [pgAdmin][RM4506] "can't execute an empty query" messagedisplayed if user remove fill factor of any existing table
Список pgadmin-hackers
Дерево обсуждения
Hi Hackers,

Attached is the updated patch. The modified SQL missed the reset clause for FILLFACTOR. That's added now.
I've changed the int/numeric field validation to disallow spaces in the form field. Currently,  fill factor allows spaces and fails while saving as "invalid value".
Also, added min and max for fill factor in Mview dialog.

All the test cases are passing. Kindly review.


On Mon, Dec 9, 2019 at 4:30 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

The issue has not been resolved. Remove fill factor it won't generate MSQL. Please verify and fix it. 

On Mon, Dec 9, 2019 at 3:33 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix an issue where just clicking on an empty textbox like fill factor in tables dialog considers it a change and so the save button is enabled.
The fix is common will apply at other places also.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Вложения

В списке pgadmin-hackers по дате отправления: