Re: Re : [BUG #4943]
От | Aditya Toshniwal |
---|---|
Тема | Re: Re : [BUG #4943] |
Дата | |
Msg-id | CAM9w-_=TTvNZcYBq4q=XJyZdsL9UQc3vNzVZ5an7ML8kuO+U6g@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Re : [BUG #4943] (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>) |
Список | pgadmin-hackers |
Hi Karan,
Kindly add a hyphen between the message and names, create a patch to pgAdmin hackers(check cc).
Kindly also run the test cases and pep8 before sending.
On Mon, Dec 9, 2019, 20:17 Karan Takalkar <karan1533os@gmail.com> wrote:
I have updated the success message.Please check the screenshots attached.Should i make a patch?Regards,KaranOn Mon, 9 Dec, 2019, 3:25 PM Aditya Toshniwal, <aditya.toshniwal@enterprisedb.com> wrote:++pgadmin-hackersHi Karan,It is good to know that you're contributing.I would suggest {server name}/{db name} as name instead of did is better for UX. You can get the db name from conn object and server name using the sid (refer - web/pgadmin/browser/server_groups/servers/__init__.py)On Mon, Dec 9, 2019 at 3:11 PM Karan Takalkar <karan1533os@gmail.com> wrote:Hi,I have been working on #4943 ("Database connected" success message itself is not enough) added by you on pgAdmin4 issues.I want to know what details of database should be included in success message.(i have added 'did')The success message can be modified by altering json response in the connect method in file PGADMIN_SRC/web/pgadmin/browser/server_groups/servers/databases/__init__.py.please have a look at the screenshots attached.original:info=_( "Database connected.")new:info=_("Postgres version/{0} Database connected.".format(did))Regards,Karan--Thanks and Regards,Aditya ToshniwalSr. Software Engineer | EnterpriseDB India | Pune"Don't Complain about Heat, Plant a TREE"
В списке pgadmin-hackers по дате отправления: