Re: factor out encoding dependent json/jsonb regression tests
От | Peter Geoghegan |
---|---|
Тема | Re: factor out encoding dependent json/jsonb regression tests |
Дата | |
Msg-id | CAM3SWZRuSXjVWN7ikjUFqEWLvuKTD7=jVh5VO+PSYKo+-f63YA@mail.gmail.com обсуждение исходный текст |
Ответ на | factor out encoding dependent json/jsonb regression tests (Andrew Dunstan <andrew@dunslane.net>) |
Список | pgsql-hackers |
On Mon, Oct 5, 2015 at 10:32 AM, Andrew Dunstan <andrew@dunslane.net> wrote: > I'm rather tired of having to update two sets of output files every time we > change the json and jsonb regression tests. Also, other committers > occasionally fall over this trap and fail to update json_1.out and > jsonb_1.out, as do almost all other patch authors. I propose that we remove > those tests to quite small json_utf8.sql and jsonb_utf8.sql (which will each > have 2 output files) and that will allow us to get rid of json_1.out and > jsonb_1.out. I'd like to backpatch this to 9.4 for jsonb and 9.2 for json. > Alternatively, for >= 9.4 we could just add the jsonb encoding-specific > tests to json_utf8.sql, to avoid a greater proliferation of tests. While I figured out a way of dealing with that that is minimally annoying, it is a little confusing. +1 to doing this, and +1 to backpatching. I don't think that there is actually very much different between each output. -- Peter Geoghegan
В списке pgsql-hackers по дате отправления: