Re: patch: option --if-exists for pg_dump

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: patch: option --if-exists for pg_dump
Дата
Msg-id CAM2+6=Vu_mQWK=0ur7mHhpSAYqumotd_cCcpMaDYA9ckdiOTRg@mail.gmail.com
обсуждение исходный текст
Ответ на Re: patch: option --if-exists for pg_dump  (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы Re: patch: option --if-exists for pg_dump
Список pgsql-hackers
Дерево обсуждения
Hi Peter,

I am not sure why you getting build unstable due to white-space errors.

Are you referring to these line ?

11:25:01 src/bin/pg_dump/pg_backup_archiver.c:477: indent with spaces.
11:25:01 +													    dropStmt,
11:25:01 src/bin/pg_dump/pg_backup_archiver.c:478: indent with spaces.
11:25:10 +													    buffer,
11:25:14 src/bin/pg_dump/pg_backup_archiver.c:479: indent with spaces.
11:25:15 +													    mark + l);
11:25:15 + echo unstable

If yes, then in my latest attached patch, these lines are NOT AT ALL there.
I have informed on my comment that I have fixed these in my version of patch,
but still you got unstable build. NOT sure how. Seems like you are applying
wrong patch.

Will you please let us know what's going wrong ?

Thanks



On Thu, Jan 30, 2014 at 6:56 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:



2014-01-30 Jeevan Chalke <jeevan.chalke@enterprisedb.com>:

OK.

Assigned it to committer.

Thanks for the hard work.

Thank you for review

Pavel
 


On Thu, Jan 30, 2014 at 6:16 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
Hello

All is ok

Thank you

Pavel
 
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company





--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91 20 30589500

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.

В списке pgsql-hackers по дате отправления: