Re: [PATCH] Revive line type

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: [PATCH] Revive line type
Дата
Msg-id CAM2+6=UQqUWOcY+Lb3AoT1Swz2=cO7_SmdH3mW-t+_ZGpjj2Dw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Revive line type  (Peter Eisentraut <peter_e@gmx.net>)
Ответы Re: [PATCH] Revive line type
Список pgsql-hackers
Дерево обсуждения



On Wed, Oct 2, 2013 at 6:12 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
On Wed, 2013-09-25 at 14:26 +0530, Jeevan Chalke wrote:
> So no issues from my side.
>
> However, do we still need this in close_pl() ?
>
> #ifdef NOT_USED
>     if (FPeq(line->A, -1.0) && FPzero(line->B))
>     {                            /* vertical */
>     }
> #endif

No, that can be removed.

Will you please attach new patch with above block removed ? Then I will quickly check that new patch and mark as "Ready For Committer".
 

> Also close_sl, close_lb and dist_lb are NOT yet implemented. It will
> be good if we have those. But I don't think we should wait for those
> functions to be implemented.

Right, those are separate projects.

Agree.


Thanks
--
Jeevan B Chalke

В списке pgsql-hackers по дате отправления: