Re: patch: option --if-exists for pg_dump

Поиск
Список
Период
Сортировка
От Jeevan Chalke
Тема Re: patch: option --if-exists for pg_dump
Дата
Msg-id CAM2+6=UH76KtU1_xORkBzF3_MUnkPoK2EYeaowk22s6Nbyup+g@mail.gmail.com
обсуждение исходный текст
Ответ на Re: patch: option --if-exists for pg_dump  (Pavel Stehule <pavel.stehule@gmail.com>)
Ответы Re: patch: option --if-exists for pg_dump
Список pgsql-hackers
Дерево обсуждения
Hi Pavel,

Now the patch looks good to me. However when I try to restore your own sql file's dump, I get following errors:

pg_restore: [archiver (db)] could not execute query: ERROR:  relation "public.emp" does not exist
    Command was: DROP TRIGGER IF EXISTS emp_insert_trigger ON public.emp;

pg_restore: [archiver (db)] could not execute query: ERROR:  schema "myschema" does not exist
    Command was: DROP FUNCTION IF EXISTS myschema.int_to_date(integer);

Is that expected after your patch ?

Also, I didn't quite understand these lines of comments:

                        /*
                         * Descriptor string (te-desc) should not be same as object
                         * specifier for DROP STATEMENT. The DROP DEFAULT has not
                         * IF EXISTS clause - has not sense.
                         */

Will you please rephrase ?

Thanks
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

В списке pgsql-hackers по дате отправления: