On Wed, 12 Oct 2022 at 01:10, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Sep 13, 2022 at 05:31:05PM +0900, Kyotaro Horiguchi wrote:
> > And ExportSnapshot repalces oversized subxip with overflowed.
> >
> > So even when GetSnapshotData() returns a snapshot with oversized
> > subxip, it is saved as just "overflowed" on exporting. I don't think
> > this is the expected behavior since such (no xip and overflowed)
> > snapshot no longer works.
> >
> > On the other hand, it seems to me that snapbuild doesn't like
> > takenDuringRecovery snapshots.
> >
> > So snapshot needs additional flag signals that xip is oversized and
> > all xid are holded there. And also need to let takenDuringRecovery
> > suggest subxip is oversized.
>
> The discussion seems to have stopped here. As this is classified as a
> bug fix, I have moved this patch to next CF, waiting on author for the
> moment.
Kyotoro Horiguchi, any chance you'll be able to work on this for this
commitfest? If so shout (or anyone else is planning to push it over
the line.... Andres?) otherwise I'll move it on to the next release.
--
Gregory Stark
As Commitfest Manager