Re: [PATCH] minor reloption regression tests improvement

Поиск
Список
Период
Сортировка
От Greg Stark
Тема Re: [PATCH] minor reloption regression tests improvement
Дата
Msg-id CAM-w4HODaFSVjz0R4XMYeN+bbEhcq0=H-hwq3TLSL-OriiUHpA@mail.gmail.com
обсуждение исходный текст
Ответ на [PATCH] minor reloption regression tests improvement  (Nikolay Shaplov <dhyan@nataraj.su>)
Ответы Re: [PATCH] minor reloption regression tests improvement  (Nikolay Shaplov <dhyan@nataraj.su>)
Re: [PATCH] minor reloption regression tests improvement  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Список pgsql-hackers
I don't think this is worth spending time adding tests for. I get what
you're saying that this is at least semi-intentional behaviour and
desirable behaviour so it should have tests ensuring that it continues
to work. But it's not documented behaviour and the test is basically
testing that the implementation is this specific implementation.

I don't think the test is really a bad idea but neither is it really
very useful and I think it's not worth having people spend time
reviewing and discussing. I'm leaning to saying this patch is
rejected.



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "David G. Johnston"
Дата:
Сообщение: Re: role self-revocation
Следующее
От: Zhihong Yu
Дата:
Сообщение: refreshing query id for pg_stat_statements based on comment in sql