Re: Error-safe user functions
| От | Ted Yu |
|---|---|
| Тема | Re: Error-safe user functions |
| Дата | |
| Msg-id | CALte62yWudMKgiv1egAqD2Q0hPSDxT9h7yg21jqgBCLktAde0g@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Error-safe user functions (Tom Lane <tgl@sss.pgh.pa.us>) |
| Ответы |
Re: Error-safe user functions
|
| Список | pgsql-hackers |
On Fri, Dec 23, 2022 at 1:22 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Ted Yu <yuzhihong@gmail.com> writes:
> In makeItemLikeRegex :
> + /* See regexp.c for explanation */
> + CHECK_FOR_INTERRUPTS();
> + pg_regerror(re_result, &re_tmp, errMsg,
> sizeof(errMsg));
> + ereturn(escontext, false,
> Since an error is returned, I wonder if the `CHECK_FOR_INTERRUPTS` call is
> still necessary.
Yes, it is. We don't want a query-cancel transformed into a soft error.
regards, tom lane
Hi,
`ereturn(escontext` calls appear in multiple places in the patch.
What about other callsites (w.r.t. checking interrupt) ?
Cheers
В списке pgsql-hackers по дате отправления: