Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL

Поиск
Список
Период
Сортировка
От Ted Yu
Тема Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL
Дата
Msg-id CALte62y8XrE=AZZHxdcuP=C0u5=HFWAEt3tBpO60pfSbqqwvWw@mail.gmail.com
обсуждение исходный текст
Ответ на RE: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL  ("houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>)
Ответы Re: releasing ParallelApplyTxnHash when pa_launch_parallel_worker returns NULL  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
Дерево обсуждения


On Tue, Jan 10, 2023 at 7:55 PM houzj.fnst@fujitsu.com <houzj.fnst@fujitsu.com> wrote:
On Wednesday, January 11, 2023 10:21 AM Ted Yu <yuzhihong@gmail.com> wrote:
>         /* First time through, initialize parallel apply worker state hashtable. */
>         if (!ParallelApplyTxnHash)
>
> I think it would be better if `ParallelApplyTxnHash` is created by the first
> successful parallel apply worker.

Thanks for the suggestion. But I am not sure if it's worth to changing the
order here, because It will only optimize the case where user enable parallel
apply but never get an available worker which should be rare. And in such a
case, it'd be better to increase the number of workers or disable the parallel mode.

Best Regards,
Hou zj

I think even though the chance is rare, we shouldn't leak resource.

The `ParallelApplyTxnHash` shouldn't be created if there is no single apply worker.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: John Naylor
Дата:
Сообщение: Re: [PATCH] Improve ability to display optimizer analysis using OPTIMIZER_DEBUG
Следующее
От: "houzj.fnst@fujitsu.com"
Дата:
Сообщение: RE: Perform streaming logical transactions by background workers and parallel apply