Re: Move backup-related code to xlogbackup.c/.h

On Wed, Oct 19, 2022 at 4:23 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2022-Oct-19, Bharath Rupireddy wrote:
>
> > When the standby is in recovery, calls to XLogInsertRecord() or
> > AdvanceXLInsertBuffer()) where forcePageWrites is being used, won't
> > happen, no?
> >
> >       * Note that forcePageWrites has no effect during an online backup from
> > -     * the standby.
> > +     * the standby.   XXX what does this mean??
>
> Well, yes, but when looking at this comment I wonder why do I *care*
> about this point.  I left this comment has you changed it, but I wonder
> if we shouldn't just remove it.

Well,retaining that comment does no harm IMO.

> > I removed the 2 more instances of forcePageWrites left-out and tweaked
> > the comments a little and attached 0002.
>
> Thanks for looking.  Pushed now.

Thanks. I will rebase and post the other patches soon.

-- 
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com