Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)

Поиск
Список
Период
Сортировка
От Bharath Rupireddy
Тема Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Дата
Msg-id CALj2ACWfLSo77qmAUE6O4_N6fYpS-3qX8EeFmAFrVZAX_xGqiA@mail.gmail.com
обсуждение исходный текст
Ответ на Fix typo with logical connector (src/backend/commands/vacuumparallel.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Ответы Re: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
On Fri, Aug 19, 2022 at 5:35 PM Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> Hi,
>
> At function parallel_vacuum_process_all_indexes there is
> a typo with a logical connector.
>
> I think that correct is &&, because both of the operators are
> bool types [1].
>
> As a result, parallel vacuum workers can be incorrectly enabled.
>
> Attached a trivial fix.
>
> [1] https://wiki.sei.cmu.edu/confluence/display/c/EXP46-C.+Do+not+use+a+bitwise+operator+with+a+Boolean-like+operand

Good catch! Patch LGTM.

-- 
Bharath Rupireddy
RDS Open Source Databases: https://aws.amazon.com/rds/postgresql/



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Ranier Vilela
Дата:
Сообщение: Fix typo with logical connector (src/backend/commands/vacuumparallel.c)
Следующее
От: Bharath Rupireddy
Дата:
Сообщение: Fix a comment in WalSnd structure