On Tue, May 11, 2021 at 6:54 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Tue, May 11, 2021 at 2:47 AM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> >
> > On 2021-May-10, vignesh C wrote:
> >
> > > That sounds fine to me, Attached v6 patch which has the changes for the same.
> >
> > What about defining a function (maybe a static inline function in
> > defrem.h) that is marked noreturn and receives the DefElem and
> > optionally pstate, and throws the error? I think that would avoid the
> > patch's need to have half a dozen copies of the "duplicate_error:" label
> > and ereport stanza.
>
> Thanks for the comment, this reduces a significant amount of code.
Yeah, the patch reduces more than 200 LOC which is a pretty good thing.
25 files changed, 239 insertions(+), 454 deletions(-)
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com