Re: Tiny update to pg_stat_statements documentation

On Wed, Apr 21, 2021 at 6:40 AM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Tue, Apr 20, 2021 at 8:06 PM Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
> > > I've attached a patch for this.
> >
> > +1. How about mentioning something like below?
> >
> > +compute_query_id = on # when in-core query identifier computation is
> > desired, otherwise off.
> >
>
> Hmm, I think that comment is perhaps slightly misleading, as
> compute_query_id wouldn't be set to "off" in settings for "typical
> usage".
> Just saying "use in-core query identifier computation" would be a
> better comment.
> However, I don't think the additional comment is really warranted
> here, as the other typical usage settings are not commented, and all
> settings are explained in the surrounding documentation.

Thanks Greg! I agree with you and withdraw my point.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com