Re: Add new error_action COPY ON_ERROR "log"
От | Bharath Rupireddy |
---|---|
Тема | Re: Add new error_action COPY ON_ERROR "log" |
Дата | |
Msg-id | CALj2ACUdBadbci8CiFeBJwsgZ=pFHomMcheR3kHsgmw7usOAGw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: Add new error_action COPY ON_ERROR "log" (Masahiko Sawada <sawada.mshk@gmail.com>) |
Ответы |
Re: Add new error_action COPY ON_ERROR "log"
|
Список | pgsql-hackers |
On Tue, Mar 26, 2024 at 9:56 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > > errmsg("data type incompatibility at line %llu for column %s: \"%s\"", > > > > I guess it would be better to make the log message clearer to convey > > > what we did for the malformed row. For example, how about something > > > like "skipping row due to data type incompatibility at line %llu for > > > column %s: \"s\""? > > > > The summary message which gets printed at the end says that "NOTICE: > > 6 rows were skipped due to data type incompatibility". Isn't this > > enough? If someone is using ON_ERROR 'ignore', it's quite natural that > > such rows get skipped softly and the summary message can help them, > > no? > > I think that in the main log message we should mention what happened > (or is happening) or what we did (or are doing). If the message "data > type incompatibility ..." was in the DETAIL message with the main > message saying something like "skipping row at line %llu for column > %s: ...", it would make sense to me. But the current message seems not > to be clear to me and consistent with other NOTICE messages. Also, the > last summary line would not be written if the user cancelled, and > someone other than person who used ON_ERROR 'ignore' might check the > server logs later. Agree. I changed the NOTICE message to what you've suggested. Thanks. -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Вложения
В списке pgsql-hackers по дате отправления: