Re: Unit tests for SLRU
| От | Pavel Borisov |
|---|---|
| Тема | Re: Unit tests for SLRU |
| Дата | |
| Msg-id | CALT9ZEF447SpmPAOKipZz9zkHyRvQ8835cV8c71+9RFNT+UG4g@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Unit tests for SLRU (Aleksander Alekseev <aleksander@timescale.com>) |
| Ответы |
Re: Unit tests for SLRU
|
| Список | pgsql-hackers |
Hi hackers,
> Here is version 3 of the patch.
> [...]
> I think the tests are about as good as they will ever get.
Here is version 4. Same as v3, but with resolved conflicts against the
current `master` branch.
Hi, Alexander!
The test seems good enough to be pushed.
Only one thing to note. Maybe it would be good not to copy-paste Assert after every call of SimpleLruInit, putting it into the wrapper function instead. So the test can call calling the inner function (without assert) and all other callers using the wrapper. Not sure about naming though. Maybe rename current SimpleLruInit -> SimpleLruInitInner and a new wrapper being under the old name (SimpleLruInit).
--
В списке pgsql-hackers по дате отправления: