Re: Dump public schema ownership & seclabels
| От | Zhihong Yu |
|---|---|
| Тема | Re: Dump public schema ownership & seclabels |
| Дата | |
| Msg-id | CALNJ-vSqGYkEDx3i16Bne-D224dWBRpatweTbiu0qY6uQmDu9A@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Dump public schema ownership & seclabels (Asif Rehman <asifr.rehman@gmail.com>) |
| Ответы |
Re: Dump public schema ownership & seclabels
|
| Список | pgsql-hackers |
On Sat, May 1, 2021 at 8:16 AM Asif Rehman <asifr.rehman@gmail.com> wrote:
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: not tested
Hi,
I have tested this patch. This patch still applies and it works well.
Regards,
Asif
The new status of this patch is: Ready for Committer
For public-schema-comment-dump-v2.patch :
+ if (ncomments == 0)
+ {
+ comments = &empty_comment;
+ ncomments = 1;
+ }
+ else if (strcmp(comments->descr, (fout->remoteVersion >= 80300 ?
+ "standard public schema" :
+ "Standard public schema")) == 0)
+ {
+ ncomments = 0;
+ {
+ comments = &empty_comment;
+ ncomments = 1;
+ }
+ else if (strcmp(comments->descr, (fout->remoteVersion >= 80300 ?
+ "standard public schema" :
+ "Standard public schema")) == 0)
+ {
+ ncomments = 0;
Is it possible that, in the case ncomments > 0, there are more than one comment ?
If not, an assertion can be added in the second if block above.
Cheers
В списке pgsql-hackers по дате отправления: