Re: ResourceOwner refactoring
| От | Zhihong Yu |
|---|---|
| Тема | Re: ResourceOwner refactoring |
| Дата | |
| Msg-id | CALNJ-vSjN9fsLApo8qxr-NtGGSBkfsHOQV5n4jgEdJwMHgxvEA@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: ResourceOwner refactoring (Heikki Linnakangas <hlinnaka@iki.fi>) |
| Ответы |
Re: ResourceOwner refactoring
|
| Список | pgsql-hackers |
On Wed, Jul 14, 2021 at 7:40 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
On 14/07/2021 17:07, Alvaro Herrera wrote:
> On 2021-Jul-14, vignesh C wrote:
>
>> On Tue, Mar 9, 2021 at 6:10 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
>>> Here you go.
>>
>> The patch does not apply on Head anymore, could you rebase and post a
>> patch. I'm changing the status to "Waiting for Author".
>
> Support for hmac was added by e6bdfd9700eb so the rebase is not trivial.
Yeah, needed some manual fixing, but here you go.
- Heikki
Hi,
For the loop over the hash:
{
- if (olditemsarr[i] != resarr->invalidval)
- ResourceArrayAdd(resarr, olditemsarr[i]);
+ while (owner->hash[idx].kind != NULL &&
+ owner->hash[idx].kind->phase == phase)
...
+ } while (capacity != owner->capacity);
Since the phase variable doesn't seem to change for the while loop, I wonder what benefit the while loop has (since the release is governed by phase).
Cheers
В списке pgsql-hackers по дате отправления: