Re: Allow batched insert during cross-partition updates
| От | Zhihong Yu |
|---|---|
| Тема | Re: Allow batched insert during cross-partition updates |
| Дата | |
| Msg-id | CALNJ-vS8x5OfZvgGR-9A43qfauQoDPfDht_0H-iUa-i9JAzkDw@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Allow batched insert during cross-partition updates (Amit Langote <amitlangote09@gmail.com>) |
| Ответы |
Re: Allow batched insert during cross-partition updates
|
| Список | pgsql-hackers |
Hi,
In the description:
cross-partition update of partitioned tables can't use batching
because ExecInitRoutingInfo() which initializes the insert target
because ExecInitRoutingInfo() which initializes the insert target
'which' should be dropped since 'because' should start a sentence.
+-- Check that batched inserts also works for inserts made during
inserts also works -> inserts also work
+ Assert(node->rootResultRelInfo->ri_RelationDesc->rd_rel->relkind ==
+ RELKIND_PARTITIONED_TABLE);
+ RELKIND_PARTITIONED_TABLE);
The level of nested field accesses is quite deep. If the assertion fails, it would be hard to know which field is null.
Maybe use several assertions:
Assert(node->rootResultRelInfo)
Assert(node->rootResultRelInfo->ri_RelationDesc)
Assert(node->rootResultRelInfo->ri_RelationDesc->rd_rel->relkind == ...
Cheers
On Sun, Apr 4, 2021 at 8:06 AM Amit Langote <amitlangote09@gmail.com> wrote:
On Tue, Mar 16, 2021 at 6:13 PM <gkokolatos@pm.me> wrote:
> Status updated to RfC in the commitfest app.
Patch fails to apply per cfbot, so rebased.
--
Amit Langote
EDB: http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: