Re: [POC] Fast COPY FROM command for the table with foreign partitions
| От | Zhihong Yu |
|---|---|
| Тема | Re: [POC] Fast COPY FROM command for the table with foreign partitions |
| Дата | |
| Msg-id | CALNJ-vRi4DjjkCmvmXWWtULzY6PSeEAC9vSpXVNHyVoGEQ8HVQ@mail.gmail.com обсуждение исходный текст |
| Ответ на | RE: [POC] Fast COPY FROM command for the table with foreign partitions ("tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>) |
| Список | pgsql-hackers |
Hi,
In the description:
with data_dest_cb callback. It is used for send text representation of a tuple to a custom destination.
send text -> sending text
struct PgFdwModifyState *aux_fmstate; /* foreign-insert state, if
* created */
+ CopyToState cstate; /* foreign COPY state, if used */
* created */
+ CopyToState cstate; /* foreign COPY state, if used */
Since foreign COPY is optional, should cstate be a pointer ? That would be in line with aux_fmstate.
Cheers
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
> Macros _() at the postgresExecForeignCopy routine:
> if (PQputCopyEnd(conn, OK ? NULL : _("canceled by server")) <= 0)
>
> uses gettext. Under linux it is compiled ok, because (as i understood)
> uses standard implementation of gettext:
> objdump -t contrib/postgres_fdw/postgres_fdw.so | grep 'gettext'
> gettext@@GLIBC_2.2.5
>
> but in MacOS (and maybe somewhere else) we need to explicitly link
> libintl library in the Makefile:
> SHLIB_LINK += $(filter -lintl, $(LIBS)
>
> Also, we may not use gettext at all in this part of the code.
I'm afraid so, because no extension in contrib/ has po/ directory. I just removed _() and rebased the patch on HEAD.
Regards
Takayuki Tsunakawa
В списке pgsql-hackers по дате отправления: