Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

Поиск
Список
Период
Сортировка
От Zhihong Yu
Тема Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Дата
Msg-id CALNJ-vRee1RmHgzV=-_B=6AN3L_CCuAjdzej5XxhfHR6iT2K5w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Add SPLIT PARTITION/MERGE PARTITIONS commands  (Zhihong Yu <zyu@yugabyte.com>)
Ответы Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Список pgsql-hackers
Дерево обсуждения


On Tue, Oct 11, 2022 at 9:58 AM Zhihong Yu <zyu@yugabyte.com> wrote:


On Tue, Oct 11, 2022 at 9:22 AM Dmitry Koval <d.koval@postgrespro.ru> wrote:
Hi!

Fixed couple warnings (for cfbot).

--
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com
Hi,
For v12-0001-PGPRO-ALTER-TABLE-MERGE-PARTITIONS-command.patch:

+       if (equal(name, cmd->name))
+           /* One new partition can have the same name as merged partition. */
+           isSameName = true;

I think there should be a check before assigning true to isSameName - if isSameName is true, that means there are two partitions with this same name.

Cheers 

Pardon - I see that transformPartitionCmdForMerge() compares the partition names.
Maybe you can add a comment in ATExecMergePartitions referring to transformPartitionCmdForMerge() so that people can more easily understand the logic.

В списке pgsql-hackers по дате отправления: