Re: Making Vars outer-join aware

Поиск
Список
Период
Сортировка
От Zhihong Yu
Тема Re: Making Vars outer-join aware
Дата
Msg-id CALNJ-vQ_0iHqCsD8MAwBAJKj-O4KVe1jf0d_hWZcDrTsHWOf3Q@mail.gmail.com
обсуждение исходный текст
Ответ на Re: Making Vars outer-join aware  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: Making Vars outer-join aware
Список pgsql-hackers
Дерево обсуждения


On Mon, Aug 1, 2022 at 12:51 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Here's a rebase up to HEAD, mostly to placate the cfbot.
I accounted for d8e34fa7a (s/all_baserels/all_query_rels/
in those places) and made one tiny bug-fix change.
Nothing substantive as yet.

                        regards, tom lane

Hi,
For v3-0003-label-Var-nullability-in-parser.patch :

+   if (rtindex > 0 && rtindex <= list_length(pstate->p_nullingrels))
+       relids = (Bitmapset *) list_nth(pstate->p_nullingrels, rtindex - 1);
+   else
+       relids = NULL;
+
+   /*
+    * Merge with any already-declared nulling rels.  (Typically there won't
+    * be any, but let's get it right if there are.)
+    */
+   if (relids != NULL)

It seems the last if block can be merged into the previous if block. That way `relids = NULL` can be omitted.

Cheers 

В списке pgsql-hackers по дате отправления: