Re: Different error messages executing CREATE TABLE or ALTER TABLE to create a column "xmin"

On Thu, Jan 26, 2012 at 17:58, Robert Haas <span dir="ltr"><<a
href="mailto:robertmhaas@gmail.com">robertmhaas@gmail.com</a>></span>wrote:<br /><div
class="gmail_quote"><blockquoteclass="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc
solid;padding-left:1ex"><divclass="HOEnZb"><div class="h5">On Thu, Jan 26, 2012 at 11:29 AM, Tom Lane <<a
href="mailto:tgl@sss.pgh.pa.us">tgl@sss.pgh.pa.us</a>>wrote:<br /> > This looks reasonable to me, except that
possiblythe new error message<br /> > text could do with a bit more thought.  It seems randomly unlike the<br />
>normal message, and I also have a bit of logical difficulty with the<br /> > wording equating a "column" with a
"columnname".  The wording that<br /> > is in use in the existing CREATE TABLE case is<br /> ><br /> > column
name\"%s\" conflicts with a system column name<br /> ><br /> > We could do worse than to use that verbatim, so as
toavoid introducing<br /> > a new translatable string.  Another possibility is<br /> ><br /> > column \"%s\"
ofrelation \"%s\" already exists as a system column<br /> ><br /> > Or we could keep the primary errmsg the same
asit is for a normal<br /> > column and instead add a DETAIL explaining that this is a system column.<br /><br
/></div></div>Iintended for the message to match the CREATE TABLE case.  I think it<br /> does, except I see now that
Vik'spatch left out the word "name" where<br /> the original string has it.  So I'll vote in favor of your first<br />
option,above, since that's what I intended anyway.<br /></blockquote></div><br />My intention was to replicate the
CREATETABLE message; I'm not sure how I failed on that particular point.  Thank you guys for noticing and fixing it
(alongwith all the other corrections).<br /><br />