Re: Introduce XID age and inactive timeout based replication slot invalidation

On Mon, 10 Feb 2025 at 17:33, Nisha Moond <nisha.moond412@gmail.com> wrote:
>
> Here are the v73 patches incorporating the comments above and the
> subsequent comments from [1].
>  - patch 002 is rebased on 001 with no new changes.

Few comments:
1) For some reason SlotInvalidationCauses was with PGDLLIMPORT, this
is removed now. This is required if it needs to be accessible by
loaded modules. Is there any impact or is it ok?
-extern PGDLLIMPORT const char *const SlotInvalidationCauses[];
+typedef struct SlotInvalidationCauseMap
+{
+       int                     cause;
+       const char *cause_name;
+}                      SlotInvalidationCauseMap;

2) The new structure should be added to typedefs.list:
+typedef struct SlotInvalidationCauseMap
+{
+       int                     cause;
+       const char *cause_name;
+}                      SlotInvalidationCauseMap;

3) After adding you can run pgindent on slot.h to indent the following code:
+typedef struct SlotInvalidationCauseMap
+{
+       int                     cause;
+       const char *cause_name;
+}                      SlotInvalidationCauseMap;

Regards,
Vignesh