Re: Is ParsePrepareRecord dead function

On Tue, Jul 30, 2019 at 2:34 AM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>
> On 2019-Jul-29, vignesh C wrote:
>
> > On Mon, Jul 29, 2019 at 8:24 PM Robert Haas <robertmhaas@gmail.com> wrote:
> > >
> > > On Mon, Jul 29, 2019 at 4:10 AM vignesh C <vignesh21@gmail.com> wrote:
> > > > I could not locate the caller of ParsePrepareRecord function in twophase.c.
> > > > Any idea how it gets called?
> > > > or
> > > > Is it a dead function?
> > >
> > > It looks like it's not only dead, but stillborn.  Commit
> > > 1eb6d6527aae264b3e0b9c95aa70bb7a594ad1cf introduced it but without
> > > introducing any code that called it, and nothing has changed since
> > > then.
> >
> > I feel the code can be safely removed.
> > Patch for the same is attached.
>
> I think there's a patch from Fujii Masao that touches that?  Might be
> premature to remove it.
>
Ok, it makes sense not to remove it when there is some work being done in
different thread.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com