On Wed, 26 Jun 2024 at 14:41, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Here are my initial review comments for the first patch v20240625-0001.
>
> ======
> General
>
> 6.
> I saw that RelationNeedsWAL() is called 2 times. It may make no sense,
> but is it possible to assign that to a variable 1st time so you don't
> need to call it 2nd time within the critical section?
>
I felt this is ok, we do similarly in other places also like
fill_seq_fork_with_data function in the same file.
I have fixed the other comments and merged the nitpicks changes. The
attached patch has the changes for the same.
Regards,
Vignesh