Re: Questions/Observations related to Gist vacuum
| От | Mahendra Singh Thalor |
|---|---|
| Тема | Re: Questions/Observations related to Gist vacuum |
| Дата | |
| Msg-id | CAKYtNAoTDsc+Dgn2+A35v-YKt9qtXcjNMRhUo-3k8=UoAmwL+A@mail.gmail.com обсуждение исходный текст |
| Ответ на | Re: Questions/Observations related to Gist vacuum (Amit Kapila <amit.kapila16@gmail.com>) |
| Ответы |
Re: Questions/Observations related to Gist vacuum
|
| Список | pgsql-hackers |
On Mon, 9 Dec 2019 at 14:37, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > I have modified the patch for the above points and additionally ran
> > pgindent. Let me know what you think about the attached patch?
> >
>
> A new version with a slightly modified commit message.
+ * These are used to memorize all internal and empty leaf pages. They are
+ * used for deleting all the empty pages.
*/
After dot, there should be 2 spaces. Earlier, there was 2 spaces.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
>
> On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > I have modified the patch for the above points and additionally ran
> > pgindent. Let me know what you think about the attached patch?
> >
>
> A new version with a slightly modified commit message.
I reviewed v4 patch and below is the one review comment:
+ * These are used to memorize all internal and empty leaf pages. They are
+ * used for deleting all the empty pages.
*/
After dot, there should be 2 spaces. Earlier, there was 2 spaces.
Other than that patch looks fine to me.
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
В списке pgsql-hackers по дате отправления: