Re: pgAdmin Event Trigger Compatibility

Поиск

Список

Период

Сортировка

От	Dinesh Kumar
Тема	Re: pgAdmin Event Trigger Compatibility
Дата	8 июля 2013 г. 16:04:15
Msg-id	CAKWsr7iAif00Z=hTaURoLQ_Fezt=kkvNCgxwS4EMkK7SzoRtxQ@mail.gmail.com обсуждение исходный текст
Ответ на	pgAdmin Event Trigger Compatibility (Dinesh Kumar <dinesh.kumar@enterprisedb.com>)
Ответы	Re: pgAdmin Event Trigger Compatibility (Dinesh Kumar <dinesh.kumar@enterprisedb.com>)
Список	pgadmin-hackers

Дерево обсуждения

On Mon, Jul 8, 2013 at 6:17 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Jul 4, 2013 at 3:10 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:
Hi Dave,

Thanks for your time.

Please find the attached new patch for the same. As per my testing on windows/linux, it's working fine.

Kindly let me know if you face any issues and suggestions.

OK, it builds fine on Mac for me now. Some initial feedback:

- Instead of "DDL_COMMAND_START", we should use "DDL COMMAND START". The same applies to similar cases.

- Can we combine the Enable and Enable Status options into one set of radio buttons, e.g. Enabled (which should be the default), Replica, Always and Disabled?

- Please fix the sizing of the box around the aforementioned radio buttons. See the screen shots for an example of what I mean. It should match the "Fires" box on dlgTrigger.