Re: [PATCH] Keeps tracking the uniqueness with UniqueKey

Поиск
Список
Период
Сортировка
От Andy Fan
Тема Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Дата
Msg-id CAKU4AWrYPQaF0PsbJ4Vdj9-bT2fUKED14=T0q+w1Gm2ui01hCw@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [PATCH] Keeps tracking the uniqueness with UniqueKey  (Andy Fan <zhihui.fan1213@gmail.com>)
Ответы Re: [PATCH] Keeps tracking the uniqueness with UniqueKey
Список pgsql-hackers
Дерево обсуждения

Just update the patch which do some test case changes.
1.    add "ANALYZE" command before running the explain.
2.    order by with an explicit collate settings.  

Thanks  Rushabh for pointing this out, or else I'd spend much more time to figure
out why I get a different order on Windows. 

3.    As for the postgres_fdw.sql,  I just copied the results.out to expected.out,  
that's should be correct based on the result.  However I added my comment
around that. 

The issue doesn't exist at all.  The confusion was introduced by a misunderstanding
of the test case (I treated count (xx)  filter (xxx) as a window function rather than an aggration
function). so just fixed the it cleanly.

Some other changes made in the new patch:
1.   Fixed bug for UniqueKey calculation for OUTER join.
2.   Fixed some typo error in comments.
3.   Renamed the field "grantee" as "guarantee".

Best Regards
Andy Fan
  
Вложения

В списке pgsql-hackers по дате отправления: