Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

On Fri, Nov 17, 2017 at 2:51 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Fri, Nov 17, 2017 at 6:46 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

I wasn't working for me in Chrome, I almost have to click second time to set proper value in checkbox & even after that it was not saving the correct state properly.

OK, well clearly that needs fixing too, but that wasn't the point of this particular ticket :-)

 

And regarding issue in runtime, I checked with windows runtime and found that Qt does not support indeterminate state for the checkbox :(

So when we set the state to false it actually is indeterminate state and if we click one more time it sets it to false.

OK, so how do we fix that? The Qt docs are quite clear that QCheckBox *does* support tri-state (see QCheckBox::setTriState(). Worst case is that we have to create our own control right?

Yes​, I also think we have to write our custom boolean editor which do not use checkbox.

 

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Nov 16, 2017 at 10:03 PM, Dave Page <dpage@pgadmin.org> wrote:

On Thu, Nov 16, 2017 at 4:30 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Dave,

On Thu, Nov 16, 2017 at 8:59 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Thu, Nov 16, 2017 at 2:04 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi,

PFA patch to fix the issue in boolean editor & also corrected feature test.

RM#2848

Testing in webkit on Mac (Qt 5.8), the problem does not appear to be solved for me. I have run make bundle, and restarted the runtime multiple times. 

​I tested in Chrome and it was working as expected, Have you tested patch with browser?​

 

It works fine in Chrome... but then, it was never broken there for me! 

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company