Re: [pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid isextremely slow and fails with large datasets

Поиск
Список
Период
Сортировка
От Murtuza Zabuawala
Тема Re: [pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid isextremely slow and fails with large datasets
Дата
Msg-id CAKKotZRs=MW93vE9zP6HtZrjHoHt_=aC-pDaCcQ7LbETqkR=3w@mail.gmail.com
обсуждение исходный текст
Ответ на Re: [pgAdmin4][Patch]: Fixed RM #2489: Copy from the results grid isextremely slow and fails with large datasets  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Список pgadmin-hackers
Дерево обсуждения
Yes, that's weird issue, copy command works fine with debugger on and fails without debugger.
I used below code to check the status of copy command.

    try {       var status = document.execCommand('copy');       console.log('Copying text command was ' + (status ? 'successful' : 'unsuccessful'));
    } catch (err) {       alert('Oops, unable to copy to clipboard');   }


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jun 29, 2017 at 6:10 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

I haven't come across this error while development as I tested the patch with Javascript debugger on. 
When I put a single break-point and then execute the code, it's giving the perfect output but not without a debugger.

I have been trying to find the solution since yesterday but couldn't. I have tried many things but didn't work for me.
So, if anyone has any clue please let me know as I am still trying.

Thanks,
Khushboo







On Wed, Jun 28, 2017 at 7:25 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 28, 2017 at 9:48 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi Khushboo,

I applied your patch and tried to copy result from grid but got below exception.
Inline image 1
Also when I pressed copy button to copy 100k rows the browser was unresponsive for ~18 seconds (though copy operation was failed).

Yes, I see the same error, no noticeable speedup, and nothing left on the clipboard.
 

-- 
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jun 28, 2017 at 6:20 PM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM #2489: Copy from the results grid is extremely slow and fails with large datasets.

Thanks,
Khushboo




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


В списке pgadmin-hackers по дате отправления: