Re: [pgadmin-hackers] [pgAdmin4] [PATCH] History Tab rewrite in React

On my machine it aborts with:

2017-05-18 09:45:14,516: ERROR pgadmin: Unable to generate javascript

2017-05-18 09:45:14,516: ERROR pgadmin: To run the app ensure that grunt is installed globally and that yarn install command runs successfully

Traceback (most recent call last):

  File "pgadmin4.py", line 64, in <module>

    raise Exception("No generated javascript, aborting")

Exception: No generated javascript, aborting

I installed grunt both locally and globally, but it didn't help.

On Thu, May 18, 2017 at 7:13 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:

Hi Matt,

I'm on macOS(10.10.5) & not able to run pgAdmin4 through console/terminal (with virtual environment activated), earlier it used to work properly but after applying given two patches it started throwing error.

After applying the patch

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ python web/pgAdmin4.py

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.

/Library/Frameworks/Python.framework/Versions/3.5/Resources/Python.app/Contents/MacOS/Python: can't open file 'web/pgAdmin4.py': [Errno 2] No such file or directory

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ python --version

Python 3.5.0

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ python web/pgAdmin4.py

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.

/Library/Frameworks/Python.framework/Versions/3.5/Resources/Python.app/Contents/MacOS/Python: can't open file 'web/pgAdmin4.py': [Errno 2] No such file or directory

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ 

 And when I removed the patch and try again then it started properly. 

After removing the patch

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ git pull

Already up-to-date.

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ python web/pgAdmin4.py

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.

Let me know if I missed anything here.

--

Regards,

Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 16, 2017 at 3:07 AM, Matthew Kleiman <mkleiman@pivotal.io> wrote:

Hi Hackers!

Don't panic, this patch is for AFTER 1.5 release. ;-)

0001-Bring-React-into-the-codebase.patch is an infrastructural change. This patch brings in the React.js library and all of the tools that are needed for us to use React code in this project. It includes a webpack bundler to package and minify our javascript, a js linter to help keep the javascript code clean, and the Grunt taskrunner to manage these tasks.

0002-Creates-query-history-list.patch replaces the existing history tab with a React-based history component. The current patch brings us to feature-parity with the current application. However, we plan on continuing work on the History tab as we discussed. This is the smallest digestible chunk of work that we could send as a committable patch after 1.5 is cut.

Next Steps for History Tab

We are continuing to improve the user experience of the history tab. We have a series of stories lined up that lead us towards a further redesigned history tab. As we add the right hand panel and each query metadata item to it, we will be removing each query metadata item from the list view accordingly. 

Here is the design from one of the later stories:

Regards,

Shruti & Matt

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company