Re: PATCH: To fix the issue in Debugger module (pgAdmin4)

On Mon, Sep 26, 2016 at 5:08 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where it was not disabling buttons after
> execution gets finished.
> RM#1227
>
> Issue:
> If user clicks on buttons after execution is complete then it was throwing
> error, expected behaviour was all button should gets disabled except execute
> button.

This is an improvement I think, but not complete:

- The info messages are now shown, but:
  - Not until execution ends, which limits their usefulness for
additional debugging. Not sure if that's easily changeable though. 

  - The line breaks in messages are displaying like this: "INFO:
Employee 1 not found <br>SELECT 1" 

It's showing properly on my side, Please clear browser cache & try again. 

- The first execution of the function worked OK, but following the
second execution, I again saw: "Debugger: Step into execution error"
as I stepped out of the RETURN statement on line 18.

This is transient issue, so need more debugging.

 

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company