Re: BUG #14334: vacuumdb.c build failure on openbsd

Hi Alvaro,
On 21 September 2016 at 10:57, Alvaro Herrera <alvherre@2ndquadrant.com> wr=
ote:
> jungleboogie0+psql@gmail.com wrote:
>
>> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-state=
ment
>> -Wendif-labels -Wmissing-format-attribute -Wformat-security
>> -fno-strict-aliasing -fwrapv -g -O2 -I../../../src/interfaces/libpq
>> -I../../../src/include -I/usr/local/include/libxml2 -I/usr/local/include
>> -I/usr/local/include  -c -o vacuumdb.o vacuumdb.c
>> vacuumdb.c:70: error: expected declaration specifiers or '...' before
>> 'fd_set'
>> vacuumdb.c: In function 'main':
>> vacuumdb.c:193: error: 'FD_SETSIZE' undeclared (first use in this
>> function)
>
> What does your select(2) manpage say about what includes are required?
> My manpage says
>
>        /* According to POSIX.1-2001 */
>        #include <sys/select.h>
>
>        /* According to earlier standards */
>        #include <sys/time.h>
>        #include <sys/types.h>
>        #include <unistd.h>
>

http://man.openbsd.org/OpenBSD-current/man2/select.2

Also has #include <sys/select.h>

I'm checking out commit
https://github.com/postgres/postgres/commit/be7f7ee5ea73626c037600b515087e8=
f98038140

(day for the vacuum changes) to see if this will build. If not, maybe
it was a change within openbsd.


> and we're not including <sys/select.h> anywhere that I can see;
> apparently we should add something like
>
> #ifdef HAVE_SYS_SELECT_H
> #include <sys/select.h>
> #endif
>
> --
> =C3=81lvaro Herrera                https://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



--=20
-------
inum: 883510009027723
sip: jungleboogie@sip2sip.info