Re: useless assignment pointer argument
От | Gaetano Mendola |
---|---|
Тема | Re: useless assignment pointer argument |
Дата | |
Msg-id | CAJycT5o4iL+1JwzkwyUfv9YVYiPOCzO1b2O+auxp-Zq93DzKjw@mail.gmail.com обсуждение исходный текст |
Ответ на | Re: useless assignment pointer argument (Andres Freund <andres@anarazel.de>) |
Список | pgsql-hackers |
<div dir="ltr">If the compiler is good the assignment is elided indeed, that's not what I meant to point out.<br /></div><br/><div class="gmail_quote"><div dir="ltr">On Thu, 28 May 2015 at 22:17 Andres Freund <<a href="mailto:andres@anarazel.de">andres@anarazel.de</a>>wrote:<br /></div><blockquote class="gmail_quote" style="margin:00 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 2015-05-28 20:14:33 +0000, Gaetano Mendola wrote:<br/> > src/backend/commands/explain.c:1692<br /> > src/backend/commands/explain.c:1874<br /> > src/backend/commands/explain.c:1986<br/> ><br /> > there is the following assignment:<br /> ><br /> > ancestors= list_delete_first(ancestors);<br /> ><br /> > but it has no effect at all being that a function parameterand not used<br /> > anymore after the assignment itself.<br /><br /> So? It costs little to nothing, and it'llmake it much less likely that<br /> a stale version of 'ancestors' is used when the code is expanded.<br /><br /> Greetings,<br/><br /> Andres Freund<br /></blockquote></div>
В списке pgsql-hackers по дате отправления: