Re: [HACKERS] Refactor handling of database attributes betweenpg_dump and pg_dumpall

On Wed, Dec 13, 2017 at 1:50 PM, Haribabu Kommi <kommi.haribabu@gmail.com> wrote:

Rebased patch attached that fixes the documentation build problem.

Latest patch applies without noise. And here are some minor comments  

+     <varlistentry>

+      <term><option>--set-db-properties</option></term>

+      <listitem>

+       <para>

+        This option is to skip create database command without ignoring the rest

+        of the DATABASE specific commands and it is used when the database already

+        exists in the restore location. This option cannot be used with either of

+        <option>-C/--create</option> or <option>-c/--clean</option> options.

+       </para>

I see the description is framed based on previous flag " --skip-default-create-db" , and I think this needs to be re-phrased to describe what it does , e.g: This option is to set database properties for already existing database without issuing create database command ....". 

+ printf(_("  --set-db-properties          dump db properties, for use by upgrade utilities only\n"));

After the discussion about its usage up-thread, this needs to be corrected.